paulodiovani / hacktoberrank

Hacktoberfest Rank
https://hacktoberrank-challenge.herokuapp.com/
MIT License
6 stars 17 forks source link

feat: Improve the design (Restyle) #39

Closed kamaladenalhomsi closed 4 years ago

kamaladenalhomsi commented 4 years ago

I noticed the website design is poor, so in this PR, I tried to improve the design as much as I can, this design is heavily inspired by the hacktoberfest website,

@paulodiovani if the design is ok, I hope you merge ASAP, so I can complete working in on what you mentioned on #8 (I will complete working on separate PRs, still need two PRs to for the hacktoberfest 😅 )

paulodiovani commented 4 years ago

Nice work, but let me give some suggestions:

FYI, you must run npm run fetch-prs several times to fill the database enough to get enough users/prs to see in the front-end.

kamaladenalhomsi commented 4 years ago

seems that you have another version of the website, that's what website looks like in my device image

paulodiovani commented 4 years ago

ops, I forgot to disable the darkreader (dark mode for all websites extension) :man_facepalming:

Please, check the other suggestions.

kamaladenalhomsi commented 4 years ago

@paulodiovani ok, I am going to work on it

kamaladenalhomsi commented 4 years ago

@paulodiovani can you merge this for now (I am seeking for 2 additional pull requests 😅)

paulodiovani commented 4 years ago

@kamaladenalhomsi sorry man, But we need at least to list the PRs links like it was before. It is just showing the username many times.

I am seeking for 2 additional pull requests

same :boat: here

kamaladenalhomsi commented 4 years ago

@paulodiovani I replaced the "Go to PR" with the "project-name/pull/number", other suggestions will be done in a separate PR.