search

paulopacitti / gruvbox-factory

🏭 convert any image to the gruvbox pallete
MIT License
687 stars 39 forks source link

KeyError: '' #3

Closed marcelofern closed 3 years ago

marcelofern commented 3 years ago

I am having the following error when converting an image: image

libs: image-go-nord==0.1.1 gruvbox-factory==0.1.1 rich==10.1.0

Python 3.9.

marcelofern commented 3 years ago

After having a quick scan through the nordic package I found this: image

Alright, no idea why this line is in there. I was able to circumvent this anomaly by adding a gruvbox_factory.PALETTE_DATA[''] = [1,2,3] somewhere in the main.py file after the add_gruvbox_palette call and before the convert_image call.

Not keen on this solution by any means, but it might give you a few clues to fix the problem.

paulopacitti commented 3 years ago

Thanks for opening an issue @marcelofern ✨ I will check on this later, thanks for investigating and sharing some tips of what might be causing the bug 🐛 If you find a solution, feel free to share it and open a PR 💟

marcelofern commented 3 years ago

No worries. I did some investigation and the root cause comes from this issue: https://github.com/Schrodinger-Hat/ImageGoNord-pip/issues/5

It seems like the proper fix is to fix that library instead. So I submitted a new pull request. In the mean while, I'd suggest to add a blank line at the end of gruvbox.txt. Here is the PR:

marcelofern commented 3 years ago

@paulopacitti in the meanwhile, you can merge this PR: https://github.com/paulopacitti/gruvbox-factory/pull/4 so that the lib isn't broken for people installing it from yesterday onwards. I've tested it locally and it fixes the problem, but I'd suggest testing on your local as well to confirm it.

paulopacitti commented 3 years ago

awesome @marcelofern! 💯 Thanks for fixing Schrodinger-Hat/ImageGoNord and opening a PR fixing it here too! I'll merge it for sure 😉