Open MarcSkovMadsen opened 4 years ago
Here are some thoughts on the version issues
Or even better solve the below problem so that custom inclusion of resources is not needed.
# Not relying on panel to include pyviz resources, except while running
# inside Jupyter, because sometimes when panel is serving multiple notebooks
# simultaneously panel will include in a notebook page resources that are
# only needed in pages of other notebooks.
Another thought for every extension the relevant .js and .css is maintained in the relevant bokeh extensions file in Panel
So at least for these we could default to always using CDN and that version.
And for Panel the panel.min.js is in panel\dist\panel.min.js. And as I understand it there will be a CDN from Panel 0.10.0.
The the question for Panel is the panel.css. Where to get that from?
Maybe the information can be compiled for each version of Panel by just creating a template with all extensions and then extracting the head scripts
Maybe it could even be done on demand by Panel and I guess there is no need to serve them as Panel and Bokeh are already being served by Panel and the rest are on a CDN.
I believe the Bokeh resources to be served can be found via the code in https://github.com/bokeh/bokeh/blob/branch-2.3/bokeh/resources.py. No need to hard code them or create advanced functionality for that is my hypothesis.
And I don't know for sure. But I can see that there has been changes in Panel within the last 3 months to make sure the css and js served is unique for each document.
Definitely the versions of panel and bokeh locally served need to be updated. Thanks to highlighting how out of date they are.
The CDN option is not my priority. My reporting needs to be servable on-premises, even when there is no access to the Internet. Serving the reports locally without internet dependencies was one of the main reasons for me to create panel-component
.
I'm running Panel 0.9.7 and Bokeh 2.2.1 and panel-components 0.1.1 and it does not work together.
I get a
Error rendering Bokeh items: either 'docid' or 'sessionid' was expected..
. See https://github.com/paulopes/panel-components/pull/5#issuecomment-701536679.The problem is that the
sessionid
is something from an old version of Bokeh.Solution
Alternatively automatically use the version of Bokeh and Panel assets compatible with the installed version of Panel and Bokeh.
Alternative context
Currently the pyproject.toml states
which as I understand it is incorrect.