search

paulovn / sparql-kernel

A Jupyter kernel to launch queries against SPARQL endpoints
BSD 3-Clause "New" or "Revised" License
98 stars 17 forks source link

Change comment separator character from # to ## #28

Closed gpotdevin closed 6 years ago

gpotdevin commented 6 years ago

Hello,

This is a proposition for an update of the seprator character for comments (within sparql queries) from # to ##. I guess the main issue is that # is in general is accepted as a valid character in uris for sparql queries (and generically in rdf). The problem is acute with the many ontologies of the obofoundry foundation which are ubiquitous in the life science/biomedical world, as until not so long ago they encouraged the use of # as part of the official uris and many of these uris are still around.

The only option to comply strictly would be to remove comments, ie. one could create a magic to deactivate comments for the queries involving uris with # characters.

Still adding comments to queries it is a very convenient feature, so maybe one could update the comment separator from '#' to '##' ? I understand this is a backward incompatible change which one might want to reject.

gpotdevin commented 6 years ago

got it wrong, will make another pull request at a later time.