paulpflug / foldername-tabs

Adds foldernames to tabs..
MIT License
16 stars 6 forks source link

Uncaught SyntaxError: Failed to execute 'querySelectorAll' on 'Element': 'ul.tab-bar> li.tab[data... #6

Closed folletto closed 8 years ago

folletto commented 9 years ago
  1. Name a folder or file with single quotes ' in the name.
  2. Open Atom with foldername-tabs enabled.
  3. Error on the selector is triggered

Atom Version: 1.1.0 System: Mac OS X 10.11.1 Thrown From: foldername-tabs package, v0.1.5

Stack Trace

Uncaught SyntaxError: Failed to execute 'querySelectorAll' on 'Element': 'ul.tab-bar> li.tab[data-type='TextEditor']> div.title[data-path='/Desktop/'test'.txt']' is not a valid selector.

At /.../.atom/foldername-tabs/lib/foldername-tabs.coffee:88

Error: Failed to execute 'querySelectorAll' on 'Element': 'ul.tab-bar> li.tab[data-type='TextEditor']> div.title[data-path='/Desktop/'ho'.txt']' is not a valid selector.
    at Error (native)
    at processAllTabs (/.../.atom/packages/foldername-tabs/lib/foldername-tabs.coffee:88:47)

Config

{
  "core": {
    "ignoredNames": [
      ".git",
      ".svn",
      ".DS_Store"
    ],
    "disabledPackages": [
      "wrap-guide",
      "atom-jsx-transform",
      "symbols-view",
      "smart-tab-name"
    ],
    "themes": [
      "atom-dark-ui-slim",
      "monokai"
    ]
  },
  "foldername-tabs": {}
}

Installed Packages

# User
atom-ctags, v4.4.0
atom-dark-ui-slim, v0.47.1
file-icons, v1.6.11
foldername-tabs, v0.1.5
language-jade, v0.6.2
language-javascript-jsx, v0.3.7
monokai, v0.18.0
pigments, v0.18.1

# Dev
No dev packages
paulpflug commented 8 years ago

thanks for reporting, should work in 0.1.6 with ' and " in path :D