Open rualark opened 4 years ago
paulrosen
commented
4 years ago I think the problem is there are too many notes for the width of the staff. If you don't set it, I think it is set to 700px. You can make it longer with staffwidth 1000 or something. It will try to space the notes out better then.
rualark
commented
4 years ago Thanks! The problem is that user changes notes interactively in visual editor and I cannot set specific staffwidth.
paulrosen
commented
4 years ago I suppose one of the options similar to wrap could be "make staff wider" that takes a number that is how close notes can be to each other and a minimum width.
I need to think about how to present that.
rualark
commented
4 years ago Yes, something like minSpacing.
eltomjan
commented
4 years ago Found interesting workaround - in case you need to move something for a bit left or right, you can add short code to JS (abcjs_basic_6.0.0-beta.8.js) and using dragging.html example... Then select element by mouse or TAB to and use left/right arrows to move.
case 37: // <-
case 39: // ->
handled = true;
this.dragTarget = this.history[index];
this.dragIndex = index;
var transform = this.dragTarget.svgEl.transform.baseVal[0];
var dir = ev.keyCode - 38;
if (transform) {
transform.matrix.e += dir;
} else this.dragTarget.svgEl.setAttribute("transform", "translate("+dir+",0)");
break;Place that to function keyboardSelection(ev) of ./src/write/selection.js In abcjs_basic_6.0.0-beta.8.js I placed that starting from line 23539.
Thought it would be nice to have separate JSON field holding updated tune elements info for particular elements, but it would be quite complex to redraw them (lot of points to change, hard to find where to update lib for this, etc.).
Hope it is not a secret, but single note C is located here Editor.tunes[0].lines[0].staff[0].voices[0][0] and looks like this (abselem.children[4] excluded):
"lines": [{
"staff": [{
"voices": [[
{
"pitches": [
{
"pitch": 0,
"verticalPos": 0,
"highestVert": 6
}
],
"duration": 0.125,
"el_type": "note",
"startChar": 0,
"endChar": 1,
"averagepitch": 0,
"minpitch": 0,
"maxpitch": 0,
"abselem": {
"tuneNumber": 0,
"duration": 0.125,
"durationClass": 0.125,
"minspacing": 1,
"x": 49.051,
"children": [
{ ... }, ...
],
"heads": [ null ],
"extra": [ null ],
"extraw": 0,
"w": 15.902000000000001,
"right": [ null, null ],
"invisible": false,
"bottom": -1.0443870967741935,
"top": 7,
"type": "note",
"specialY": {
"tempoHeightAbove": 0,
"partHeightAbove": 0,
"volumeHeightAbove": 0,
"dynamicHeightAbove": 0,
"endingHeightAbove": 0,
"chordHeightAbove": 0,
"lyricHeightAbove": 0,
"lyricHeightBelow": 0,
"chordHeightBelow": 0,
"volumeHeightBelow": 0,
"dynamicHeightBelow": 0
},
"elemset": [
{},
{}
]
}
}
]],Interesting here is also startChar / endChar which links to abc source text - thinking about logic to mix voices - in case I have multi voices in some parts (start single, ex. refrain has multi and there are some special repetitions) MIDI is generated wrong - next voices lost sync and play something/somewhere different, so easiest fix is to mix them all to one staff line before playing, but hard / slow to do by hand... But mixed voices looks ugly on sheet, so it is better to have source with separate and option to mix them before generating MIDI.
Could you please help me with controlling spacing between notes when not using wrap?
Let's look at an example, which can be viewed in abcjs editor here:
It looks like this:
Here notes are too close to each other, considering the spacing of other notes:
Here notes are too close to the bar, considering the space between the bar and the next note:
This is how it looks without text:
The problems seem the same:
It seems that these problems can be partially solved by tuning some minSpacing parameter, where can I find it?
I was able to produce a better spacing with wrap by using minSpacing = 1.1:
But still some distances from notes to bars could be better.