search

paulrouget / dzslides

DZSlides is a one-file HTML template to build slides in HTML5 and CSS3.
http://paulrouget.com/dzslides
934 stars 255 forks source link

On stage shell: Scroll when notes overflow. #100

Closed SimonSapin closed 12 years ago

hsablonniere commented 12 years ago

Even if it may seem strange to scroll with the mouse during a presentation, I also think it can be useful sometimes.

I tried to do that a long time ago but I placed the scroll bar on the left of the buttons and it was ugly.

Nice thoughts of you to put it on the right and shift the rest.

I'd like some inputs from other users before merging : @reagle, @itpastorn, @jancborchardt, @padenot, @paulrouget, @Hywan, @wasnotrice, @jonkeane, @mathjazz, @higgo...

If we agree, I may ask you to update your commit. The diff contains a lot of formatting. It's harder for other people to merge with their forks etc...

Thanks again for the idea and the work.

SimonSapin commented 12 years ago

Yes, although it may not be easy to use during a presentation, I think that this is still better than just clipping the text.

Also note that there is no scrollbar when the text is small enough, but the buttons are still farther from the right than before. I think this is okay, it’s only 20 → 30px.

Sorry about the whitespace, my editor does this automatically. This is fixed now. (I force-pushed to keep it to one commit, the commit hash changed.)

hsablonniere commented 12 years ago

Thanks very much for the forced-push. I was embarassed to ask ;-)

If there's no objection in a few days, I'll merge...

reagle commented 12 years ago

Do you have a pointer to an example/demo of the change?

hsablonniere commented 12 years ago

Just checkout the version of @SimonSapin or download the zip https://github.com/SimonSapin/dzslides/zipball/master and try to open template with the onstage shell.

reagle commented 12 years ago

I have downloaded that but don't see any overflowing notes. In any case, I doubt I would object even if I understood :) .

hsablonniere commented 12 years ago

Yeah I forgot, you have to copy paste some notes in order to have long contents and a scrollbar.

reagle commented 12 years ago

On 09/14/2012 04:26 PM, Hubert SABLONNIÈRE wrote:

Yeah I forgot, you have to copy paste some notes in order to have long contents and a scrollbar.

This goes back to my point of it'd be nice to have a more fully featured template that serves as a test suite as well.

hsablonniere commented 12 years ago

You're right. Maybe we can do it right know for this one.

@SimonSapin What would you think about updating the template.html with a "longer notes" case?

hsablonniere commented 12 years ago

Let's got for it.