Closed vuvova closed 7 years ago
Thanks. I added you as a collaborator. Feel free to merge this PR.
Thanks. But now, playing devil's advocate, I need to mention that
So, just to know for sure, what commits out of everything I have it my branch, you want me to merge?
about 862d504 — I think that in 2016 one does not need them on CSS3 attributes, but I did not test on other browsers
I think it's ok. All browsers have dropped the prefix afaik.
83245a3 — while long-awaited functionality (I personally wanted it for years), the feature is not fool-proof. That is, it works, but it's quite possible to generate a PDF that shows slides incorrectly or misses some text.
Still progress. Land it.
a85357f — header/footer are done kinda hackish, they're in the body, not on every slide. So they don't move when the slide changes. That's why I use horizontal scrolling as a transition between slides and disable header/footer in the overview. It would be much better to have them on every slide
Right. Maybe skip that one then.
new incremental syntax changes existing behaviour. Luckily, DZSlides is just one file (and that's what I love about it), so users will hardly ever upgrade DZSlides in the already existing presentation, that is backward compatibility is not really an issue. But you might still have some concerns about it.
I'm ok with this. Land it.
So, just to know for sure, what commits out of everything I have it my branch, you want me to merge?
I'm ok if you land all of them. Up to you about the header/footer thing.
Okay, thanks. Then I'll push everything — just tested, if header/footer are not used they don't affect anything (so one can use them with certain transitions and inside a slide, or one can not use them at all).
Thanks!
Here's the description of the commits: