search

paulrouget / dzslides

DZSlides is a one-file HTML template to build slides in HTML5 and CSS3.
http://paulrouget.com/dzslides
932 stars 255 forks source link

Add slide numbering. #88

Closed padenot closed 4 years ago

padenot commented 12 years ago

Here is the feature. I suppose it is implemented as discussed. To enable the feature, the user only has to uncomment two lines.

The style is in the core part. I don't know if that is appropriate, given the goal of this project, which seems to be hackability. I do not want to dig in the core features to change the color of my counter.

codeincontext commented 12 years ago

Hope I'm not stepping on Paul's toes, but he's probably going to ask you to squash those commits together.

(to merge the commits, use git rebase and squash: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)

hsablonniere commented 12 years ago

@skattyadz About that point, we decided with @paulrouget that we will not longer force contributors to do that. It will always be a pleasure if people squash/rebase/amend their commits during the pull request phase. The priority is to give people the opportunity to participate.

hsablonniere commented 12 years ago

@padenot Thanks again for your work but your commit doesn't play well with the overview mode. I let some comments on the commit.

About the core vs custom style, I think the all template.html could use a code style refactor. It would be the occasion to reorder some stuffs (like this for example). @paulrouget What do you think ?

hsablonniere commented 11 years ago

I think you pushed on the wrong branch :-(

I'll resume work on this numbering in the weeks to come.

hsablonniere commented 4 years ago

@padenot Seems I did not resume work on numbering :laughing: