search

paulrouget / dzslides

DZSlides is a one-file HTML template to build slides in HTML5 and CSS3.
http://paulrouget.com/dzslides
932 stars 255 forks source link

Details does not take text content #98

Open itpastorn opened 12 years ago

itpastorn commented 12 years ago

Details is probably not the right element to hide speaker notes. This way of using the element is not like an "accordion" in any way.

A plain old div with a class of "notes" should probably be better.

itpastorn commented 12 years ago

Or class="details"

hsablonniere commented 12 years ago

Humm yes, I was also wondering if <details> was the best choice...

Seems that http://html5doctor.com/element-index/#details says it's not the best choice for footnotes. Our usage is very similar to a footnote.

What about that ?

<div data-dz-notes>
...
</div>
itpastorn commented 12 years ago

The data attribute is for storing values. Using it in a boolean way with no value serves no purpose.

However there is a role=note that could be the best choice.

hsablonniere commented 12 years ago

Well, I agree on the fundamental about the data attributes. Sometimes I find it easier to read and less cluttered than classes.

I really like the ARIA approach. I completly forgot to check that up. Thx.

Do you feel like proposing a pull request ?

itpastorn commented 12 years ago

I'm on vacation in low bandwidth country. Give me a couple of weeks.

hsablonniere commented 12 years ago

Take your time. I'll always be happy to merge contributions... ;-)

hsablonniere commented 11 years ago

@itpastorn? Do you still feel like proposing a pull request?

itpastorn commented 11 years ago

Actually, I've just begun working on slides again this week. Answer is probably. Will try to fix this tomorrow.

hsablonniere commented 11 years ago

No rush, don't worry ;-)