Open itpastorn opened 12 years ago
Or class="details"
Humm yes, I was also wondering if <details>
was the best choice...
Seems that http://html5doctor.com/element-index/#details says it's not the best choice for footnotes. Our usage is very similar to a footnote.
What about that ?
<div data-dz-notes>
...
</div>
The data attribute is for storing values. Using it in a boolean way with no value serves no purpose.
However there is a role=note that could be the best choice.
Well, I agree on the fundamental about the data attributes. Sometimes I find it easier to read and less cluttered than classes.
I really like the ARIA approach. I completly forgot to check that up. Thx.
Do you feel like proposing a pull request ?
I'm on vacation in low bandwidth country. Give me a couple of weeks.
Take your time. I'll always be happy to merge contributions... ;-)
@itpastorn? Do you still feel like proposing a pull request?
Actually, I've just begun working on slides again this week. Answer is probably. Will try to fix this tomorrow.
No rush, don't worry ;-)
Details is probably not the right element to hide speaker notes. This way of using the element is not like an "accordion" in any way.
A plain old div with a class of "notes" should probably be better.