paulscherrerinstitute / PsiIpPackage

TCL framework to package Vivado IP-Cores
Other
13 stars 6 forks source link

Improvement: Verilog files do not have a library #25

Open patrick-studer opened 3 years ago

patrick-studer commented 3 years ago

When using the IpPackager with Verilog files, Vivado shows the following warning:

image

I guess this can be removed by not defining the "set_property library" if the fileType is VERILOG.

Addidionaly, the filetype could be derived from the fileextension (.vhd, .v, .sv)

jonasppsi commented 3 years ago

We currently have no experience with adding own verilog files to the package. If its still a matter, I will implement the different handling depending on the filetype.

patrick-studer commented 3 years ago

Because it is not a bug but an improvement, I guess it can wait... I just placed it here because Vivado throws a bunch of warnings and to get rid of unnecessary warnings is always good :)

I will find time in the next few weeks to implement this improvement and test it with the project that uses Verilog files.