minor modifications related delete and char size

paulscherrerinstitute / StreamDevice

EPICS Driver for message based I/O

GNU General Public License v3.0

28 stars 42 forks source link

minor modifications related delete and char size #14

Closed jeonghanlee closed 5 years ago

jeonghanlee commented 5 years ago

Hi Dirk,

I would like to discuss these two minor modifications. It is the self-evidence that you can see clearly. Please let me know about your opinion.

Best, Han

dirk-zimoch commented 5 years ago

About delete[]: Of course you are right. But as the elements are chars and thus there are no destructors to call, I think the bug had no consequences. About link size: This was still using the limits of an earlier EPICS version. I should probably change it later not to use any hard coded limits.

jeonghanlee commented 5 years ago

You are right, delete[] does nothing, and for link size, I fully agree with you not to use any hard coded limits. Thank you!