search

paulscherrerinstitute / StreamDevice

EPICS Driver for message based I/O
GNU General Public License v3.0
28 stars 42 forks source link

Support for percent sign in the protocol #31

Closed klemenv closed 5 years ago

klemenv commented 5 years ago

One of my hobby devices send humidity with % sign at the end. I added a pseudo converter to support that.

Second commit is a small fix to the documentation. While writing a new bus interface for the hobby device, I only found this thanks to using C++11 override feature. As I was mostly following documentation to write my code (and not the header files), this speaks to the quality of documentation. Hopefully this patch will save somebody else a bit of time.

dirk-zimoch commented 5 years ago

% in the protocol has always been possible as \%. See here in the documentation:https://paulscherrerinstitute.github.io/StreamDevice/protocol.html#str

klemenv commented 5 years ago

An overlook on my side. Anyway it was a good exercise to get to know StreamDevice internals a bit better. Thanks.

You might still consider commit 1d1fd77.

dirk-zimoch commented 5 years ago