search

paulscherrerinstitute / StreamDevice

EPICS Driver for message based I/O
GNU General Public License v3.0
28 stars 42 forks source link

Potential out of bounds access of waveformRecord #6

Closed mdavidsaver closed 6 years ago

mdavidsaver commented 6 years ago

This line was brought to my attention. It, and the following loop, look like a guaranteed out of bounds access to BPTR.

https://github.com/paulscherrerinstitute/StreamDevice/blob/836388cd2295fcd359da70ffe8020687598157ec/src/devwaveformStream.c#L118

dirk-zimoch commented 6 years ago

At a first glance I would say off by 1.

Dirk

Am 08.12.2017 um 18:45 schrieb mdavidsaver notifications@github.com<mailto:notifications@github.com>:

This line was brought to my attention. It, and the following loop, look like a guaranteed out of bounds access to BPTR.

https://github.com/paulscherrerinstitute/StreamDevice/blob/836388cd2295fcd359da70ffe8020687598157ec/src/devwaveformStream.c#L118

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/paulscherrerinstitute/StreamDevice/issues/6, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMRD36vKzrnSNYuIUMjYfrMroV05oY3Lks5s-XWdgaJpZM4Q7bS_.

dirk-zimoch commented 6 years ago

Fixed in commit 2a1f53a07affc50ecabc36beb9439d68f2158faa