Build file updates - Githubissues

mfurseman commented 2 years ago

Hi Dirk,

We are building StreamDevice for Linux / Mingw and using INSTALL_LOCATIONS under CentOS 8. This revealed a few compatibility issues that I expect others do not often see. These changes:

Add the required pre-processor definition when one includes the PCRE header and intends to statically link.
Use TIRPC when requested; this can be necessary as recent versions of GCC no longer include RPC (based on the mechanism used in asyn.)
Add a conditional pre-processor definition to prevent the redefinition of strncasecmp when _WIN32 is set for a Mingw build.
Changed boilerplate Makefiles to resemble more typical EPICS module style, removing the CONFIG_APP, and including optional user files.

mfurseman commented 2 years ago

The RPC dependency comes from Asyn, without the TIRPC change static linking fails:

/usr/bin/g++ -o streamApp -Wl,-Bstatic -L/mnt/build/support/StreamDevice/lib/linux-x86_64 -L/mnt/build/prefix/lib/linux-x86_64 -Wl,-rpath,/mnt/build/support/StreamDevice/lib/linux-x86_64 -Wl,-rpath,/mnt/build/prefix/lib/linux-x86_64           -rdynamic -m64          streamApp_registerRecordDeviceDriver.o streamAppMain.o   -lstream -lasyn -ldbRecStd -ldbCore -lca -lCom -Wl,-Bdynamic  -lpthread   -lreadline -lm -lrt -ldl -lgcc
/mnt/build/prefix/lib/linux-x86_64/libasyn.a(drvVxi11.o): In function `vxiCreateDeviceLink':
/mnt/build/support/asyn/asyn/O.linux-x86_64/../../asyn/vxi11/drvVxi11.c:320: undefined reference to `xdr_free'
/mnt/build/support/asyn/asyn/O.linux-x86_64/../../asyn/vxi11/drvVxi11.c:295: undefined reference to `clnt_sperror'
/mnt/build/prefix/lib/linux-x86_64/libasyn.a(drvVxi11.o): In function `vxiDestroyDevLink':
/mnt/build/support/asyn/asyn/O.linux-x86_64/../../asyn/vxi11/drvVxi11.c:402: undefined reference to `xdr_free'
/mnt/build/support/asyn/asyn/O.linux-x86_64/../../asyn/vxi11/drvVxi11.c:393: undefined reference to `clnt_sperror'
...

dirk-zimoch commented 2 years ago

Shouldn‘t those symbols already be in libasyn.a when you have built that one statically?

mfurseman commented 2 years ago

Ah, that is a good point. I am taking a look to see why they are not. Do you have an issue with any of the other commits?

mfurseman commented 2 years ago

For the dynamic build the libasyn.so keeps track of the dependency on libtirpc.so and everything is resolved at runtime. For the static builds it is not so simple. One either has to repackage the existing system libtirpc.a into libasyn.a, or specify the requirement to link against it when building an executable. Out of these two, I think the latter is more tidy.

dirk-zimoch commented 2 years ago

Need to check later. I‘m on vacation now. :-)

mfurseman commented 2 years ago

Okay, enjoy your leave!

mfurseman commented 2 years ago

@dirk-zimoch Did you have a chance to look at these changes?

dirk-zimoch commented 2 years ago

I have merged this (and part of Ralph's PR #80) manually into release 2.8.21

paulscherrerinstitute / StreamDevice

Build file updates #82