search

paulscherrerinstitute / ecmccfg

Module to handle configuration scripts for EtherCATMotion Controller (ECMC)
GNU General Public License v3.0
7 stars 21 forks source link

Remove ess examples #224

Closed cdn-lnk closed 2 months ago

cdn-lnk commented 2 months ago

Hi @kivel ,

This PR removes a few example folders. All of them ESS related.

They are somewhat old and do not reflect the current state of the system or ecmc/ecmccfg.

I don't think they are (and probably should not) being used by anybody.

Also since I'm the integrator for all the systems removed, if you believe fit, we can re-include them as sub modules. This way we would keep examples but we don't get all of them cloned by default and easier to update as newer versions are released.

Let me know what you think.

cdn-lnk commented 2 months ago

The submodules are hosted on ESS gitlab.

Technically, it is possible. just use git clone --recursive and you get the files. Github web interface will not redirect to ESS gitlab though.

But I'm ok if you prefer not re-introducing them.

anderssandstrom commented 2 months ago

I prefer to not add any submodules

kivel commented 2 months ago

I'm with Anders, cross facility and git-provider submodules will be a challenge. Why don't we add a section in the docs that point to examples? There could be links to the ESS-gitlab as well.