search

paulscherrerinstitute / pyzebra

GNU General Public License v3.0
3 stars 2 forks source link

hkl order in comm_export #14

Closed ivan-usov closed 4 years ago

ivan-usov commented 4 years ago

The order of hkl indices in exported files is somewhat unusual: https://github.com/paulscherrerinstitute/pyzebra/blob/32d75988b77ce4f8330f78f2fc94cc92fb84b759/pyzebra/comm_export.py#L69-L71

@JakHolzer , @zaharko Is it correct that comm/incomm files require that order? Feel free to close it, if that's the case.

JakHolzer commented 4 years ago

Hello Ivan, thank you for pointing that out. It wrong, the order needs to be hkl, not hlk. I shall fix it immediately. Thans! Jakub

čt 22. 10. 2020 v 15:13 odesílatel Ivan Usov notifications@github.com napsal:

The order of hkl indices in exported files is somewhat unusual:

https://github.com/paulscherrerinstitute/pyzebra/blob/32d75988b77ce4f8330f78f2fc94cc92fb84b759/pyzebra/comm_export.py#L69-L71

@JakHolzer https://github.com/JakHolzer , @zaharko https://github.com/zaharko Is it correct that comm/incomm files require that order? Feel free to close it, if that's the case.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/paulscherrerinstitute/pyzebra/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM2BBRV3SHSOC72JFLWSBYDSMAVWXANCNFSM4S3FYOVQ .

ivan-usov commented 4 years ago

@rsibille-psi FYI, in case you already exported some files

ivan-usov commented 4 years ago

Fixed in 0347566aeb16fc7c84d10d01dc9b289c69c110b1

@JakHolzer , also could you write "Fix #.." in the commit title/message, so that when pushed to master it will automatically close the corresponding issue? Thanks!