paulscherrerinstitute / pyzebra

GNU General Public License v3.0
3 stars 2 forks source link

merge scans #37

Closed zaharko closed 3 years ago

zaharko commented 3 years ago
  1. Presently when merge (concatenation) of scans takes place in the ccl integrate panel, the merged scan gets 'false' in export tab of the table. After 'restore scan' 'false' is not switched back to the 'true'
  2. Presently merge (concatenation) of scans works in the ccl integrate panel. Is it planned for 'the param study' panel ?
  3. We would like to have it.
ivan-usov commented 3 years ago

Concerning your second point, which criteria should be used to determine whether two "param study" scans have to be merged?

zaharko commented 3 years ago

Dear Ivan,

I would suggest in the x-value is within 0.0005 the same.

One more request - the present users use intensively pyzebra param study option, but they cannot output the fitted parameters. Can you give some ‘quick’ way to save it out of pyzebra?

Thank you Oksana On 19 Aug 2021, at 17:01, Ivan Usov @.**@.>> wrote:

Concerning your second point, which criteria should be used to determine whether two "param study" scans have to be merged?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/paulscherrerinstitute/pyzebra/issues/37#issuecomment-901989746, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMBMFVFLUR7KVQOTXQOPR4TT5UMGJANCNFSM5CLU5FNQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/paulscherrerinstitute/pyzebra/issues/37#issuecomment-901989746", "url": "https://github.com/paulscherrerinstitute/pyzebra/issues/37#issuecomment-901989746", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

ivan-usov commented 3 years ago

The fit results are displayed when each scan is selected, but I guess it's not so convenient to copy results for all scans this way. But which output format do you want to use? E.g. how to structure the output?

zaharko commented 3 years ago

Dear Ivan,

The best would be a table, one line per file In this line: param, f1amplitude, std f1_amplitude, f1_center, std_f1_center, f1_sigma, std_f1_sigma, file

Oksana

On 20 Aug 2021, at 11:51, Ivan Usov @.**@.>> wrote:

The fit results are displayed when each scan is selected, but I guess it's not so convenient to copy results for all scans this way. But which output format do you want to use? E.g. how to structure the output?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/paulscherrerinstitute/pyzebra/issues/37#issuecomment-902576149, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMBMFVHIWHQQZQVNI6OCEEDT5YQRRANCNFSM5CLU5FNQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/paulscherrerinstitute/pyzebra/issues/37#issuecomment-902576149", "url": "https://github.com/paulscherrerinstitute/pyzebra/issues/37#issuecomment-902576149", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

ivan-usov commented 3 years ago

param_study export is added in c86466b470c48ef2f42045d8b4ea85fc5476228f

ivan-usov commented 3 years ago

Could you clarify what you mean by "I would suggest in the x-value is within 0.0005 the same."

For example, in ccl_integrate we have the following procedure for merging 2 different scans: 1) check zebra_mode to be the same 2) check that all metadata parameters (ub, temp, mf, twotheta or gamma, etc.) are within the desired difference range 3) check that scan_motor (usually omega) ranges of both scans are not separated by a gap larger than a certain value If all of the above is true, then we merge those 2 scans.

So, I guess, you refer to the difference between omega values? No other checks need to be done?

zaharko commented 3 years ago

Yes, Ivan

I ment omega-value.

Oksana

On 25 Aug 2021, at 16:03, Ivan Usov @.**@.>> wrote:

Could you clarify what you mean by "I would suggest in the x-value is within 0.0005 the same."

For example, in ccl_integrate we have the following procedure for merging 2 different scans:

  1. check zebra_mode to be the same
  2. check that all metadata parameters (ub, temp, mf, twotheta or gamma, etc.) are within the desired difference range
  3. check that scan_motor (usually omega) ranges of both scans are not separated by a gap larger than a certain value If all of the above is true, then we merge those 2 scans.

So, I guess, you refer to the difference between omega values? No other checks need to be done?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/paulscherrerinstitute/pyzebra/issues/37#issuecomment-905529703, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMBMFVAQNQT5AXHX7O2JZ53T6TZ33ANCNFSM5CLU5FNQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/paulscherrerinstitute/pyzebra/issues/37#issuecomment-905529703", "url": "https://github.com/paulscherrerinstitute/pyzebra/issues/37#issuecomment-905529703", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]