paulsengroup / hictk

Blazing fast toolkit to work with .hic and .cool files
MIT License
22 stars 1 forks source link

Support for fetching interactions from the lower triangle when it makes sense #179

Closed robomics closed 3 months ago

robomics commented 3 months ago

Support fetching interactions from the matrix lower triangle in the following scenarios:

Iterating over pixels from the lower triangle is not (and will never be) possible, as doing so would require pre-loading and re-sorting all pixels overlapping a query (defeating the purpose of iterators).

Closes #174 Closes #175

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 85.10%. Comparing base (9f426e7) to head (627bd08). Report is 21 commits behind head on main.

Files Patch % Lines
...lude/hictk/transformers/impl/to_dataframe_impl.hpp 92.99% 15 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #179 +/- ## ========================================== + Coverage 84.91% 85.10% +0.18% ========================================== Files 119 120 +1 Lines 10076 10305 +229 ========================================== + Hits 8556 8770 +214 - Misses 1520 1535 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.