Closed robomics closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.10%. Comparing base (
48341b4
) to head (a1ebfe4
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Introduce a new build knob
HICTK_WITH_ARROW_SHARED
to force dynamic linking to the Arrow libs even whenBUILD_SHARED_LIBS=OFF
.This is mostly needed to workaround a segfault that occurs under very specific conditions due to (I think) ABI incompatibilities.
The segfault occurs when the following conditions are met:
hictk
is statically linked toarrow
(the lib version does not seem to matter)hictk
is included by a third-party projectarrow
(again the lib version does not seem to matter)The segfault was observed while developing
hictkpy
(see https://github.com/paulsengroup/hictkpy/pull/56 for more details).Notably, the segfault is triggered upon calling
hictkpy::PixelSelector::to_df()
. However, for some obscure reason, this only happens for certain queries.Running the same queries directly from
hictk
through the C++ API does not result in a segfault (nor does it raise any error when buildinghictk
with ASAN).