Closed robomics closed 1 day ago
Attention: Patch coverage is 14.81481%
with 69 lines
in your changes missing coverage. Please review.
Project coverage is 74.37%. Comparing base (
2d12134
) to head (7265dd8
). Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Superseded by https://github.com/paulsengroup/hictk/pull/249.
On a second thought, there are many operations on "square" Cooler files that work out of the box: basically everything except
PixelSelector::fetch(range1, range2, ...)
and friends.So the right thing to do is to support opening "square" Cooler files, and throw an exception when one of the unsupported
PixelSelector::fetch()
method is called.This would also be a good time to introduce appropriate checks in the hictk CLI:
Cooler::Index
)