paulsengroup / hictk

Blazing fast toolkit to work with .hic and .cool files
MIT License
23 stars 1 forks source link

Fix ccache cache eviction logic when using GHA job matrix #288

Closed robomics closed 3 weeks ago

robomics commented 3 weeks ago

Basically the problem is that while we can use job matrices to the define the input params of a workflow, we cannot do the same for output params...

I think the only viable solution is to upload the cache key(s) to be deleted as an artifact, and then use one job to download all the artifacts, consolidate the cache keys, then evict cache entries as appropriate.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.36%. Comparing base (5f30972) to head (83e6bb0). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #288 +/- ## ========================================== + Coverage 79.33% 79.36% +0.02% ========================================== Files 173 173 Lines 17003 17003 Branches 2309 2309 ========================================== + Hits 13490 13494 +4 + Misses 2511 2508 -3 + Partials 1002 1001 -1 ``` | [Flag](https://app.codecov.io/gh/paulsengroup/hictk/pull/288/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) | Coverage Δ | | |---|---|---| | [tests | integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) | `69.79% <ø> (+0.03%)` | :arrow_up: | | [tests | unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) | `77.43% <ø> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.