search

paultyng / changelog-gen

Generate changelog copy from all PRs to a branch.
Mozilla Public License 2.0
5 stars 4 forks source link

Not reading release-note block #9

Open kevinkirkup opened 4 years ago

kevinkirkup commented 4 years ago

When using the terraform-provider example changelog and release-note templates, it's not reading the release-notes block unless a variable is applied.

This uses the issue title: ```release-notes Blah ```

This uses the block text ```release-notes: Some text ```

paultyng commented 4 years ago

I think in this case the issue is plural release-notes vs release-note. I can add an s to the regex though.

paultyng commented 4 years ago

Fixed in 91f787dc0cf1eedf016a444740cd28a4f1370e4d

kevinkirkup commented 4 years ago

Thanks!

Still seeing the same issue with ```release-note ```

kevinkirkup commented 4 years ago

Here is the repo/branch I'm testing with: https://github.com/pureport/terraform-provider-pureport/tree/feature/PE-2237_Automate_ChangeLog

envsetup.sh contains the function that I'm running:

  changelog-gen \
    -repo terraform-provider-pureport \
    -owner pureport \
    -branch develop \
    -changelog .ci/changelog.tmpl \
    -releasenote .ci/release-note.tmpl \
    -no-note-label "changelog: no-release-note" \
    3ea7eae2ac80e21b6190a2a6dcce15a74dd263f5 614ecfb172bd59abf00095a8c90a34e073530e9e
paultyng commented 4 years ago

Weird, there is a unit test in there testing that pattern. Is there a PR that it is not picking up? When I run this (with the default templates), this is what I get:

IMPROVEMENTS

BUGS