search

paulvanbladel / aurelia-auth

:key: Authentication plugin for aurelia
200 stars 74 forks source link

Changelog is wrong #112

Closed johnraz closed 8 years ago

johnraz commented 8 years ago

Hi there,

Am I missing something or the changelog is wrong?

paulvanbladel commented 8 years ago

sorry, should give more attentions to these details :(

johnraz commented 8 years ago

No problem at all, I was just wondering and figured I should let you know ;-)

paulvanbladel commented 8 years ago

yeah, I should check how this works, no doubt it's easy :)

johnraz commented 8 years ago

Yep, I would have kept the issue open though until it is resolved, for further reference for others that may be wondering ;-)

paulvanbladel commented 8 years ago

feel free to submit PR of course :)

RWOverdijk commented 8 years ago

@paulvanbladel gulp prepare-release

https://github.com/paulvanbladel/aurelia-auth/blob/master/build/tasks/prepare-release.js#L15

You have to change your commit style though: https://github.com/SpoonX/about/blob/master/CONTRIBUTING.md#commit

To see how that works you can check out ours: https://github.com/SpoonX/aurelia-authentication

paulvanbladel commented 8 years ago

@johnraz . gulp-conventional-changelog works better. I'll adopt the commit message conventions and we'll get from now on better change logs. Thanks for bringing it to my attention.

johnraz commented 8 years ago

No problem thanks for looking into it.