paulvanbladel / aurelia-auth

:key: Authentication plugin for aurelia
200 stars 74 forks source link

Update signup function definition in aurelia-auth.d.ts #126

Closed stuartbale closed 8 years ago

stuartbale commented 8 years ago

The signup function on auth-service supports an 'overload', where if the first argument is an object, it uses that, otherwise it generates an object from the supplied arguments:

signup(displayName, email, password) {
    let signupUrl = this.auth.getSignupUrl();
    let content;
    if (typeof arguments[0] === 'object') {
      content = arguments[0];
    } else {
      content = {
        'displayName': displayName,
        'email': email,
        'password': password
      };
    }

Would you please consider updating the aurelia-auth.d.ts Typescript definition to include this overload?

S

paulvanbladel commented 8 years ago

Would it be possible to make a PR please?

Boolos commented 8 years ago

This should be resolved with [PR #148] if you'd like to close this issue.