paulvanbladel / aurelia-auth

:key: Authentication plugin for aurelia
200 stars 74 forks source link

Use of isomorphic-fetch dependency #129

Closed MarkHerhold closed 8 years ago

MarkHerhold commented 8 years ago

Why does this library ship with a polyfilled fetch dependency? In my opinion this library should use the browser's default fetch client and end users can provide a polyfill as needed.

paulvanbladel commented 8 years ago

@mbroadst what is your view on this? Thanks.

mbroadst commented 8 years ago

this should be fine, the isomorphic-fetch was added because we were trying to use webpack and the existing module at the time imported fetch. It should be enough to simply remind the users of the library that they must import their own fetch polyfill in the event that the browser doesn't support it