search

paulvanbladel / aurelia-auth

:key: Authentication plugin for aurelia
200 stars 74 forks source link

Update FB api version from 2.3 to latest #175

Closed stephenstroud closed 7 years ago

stephenstroud commented 7 years ago

Any plans on updating the 2.2v as it will be retied on the July 8, 2017

https://developers.facebook.com/docs/apps/changelog

paulvanbladel commented 7 years ago

Happy to merge a PR.

RWOverdijk commented 7 years ago

@stephenstroud Isn't it just part of the docs? I don't think it matters as long as you configure your providers correctly.

stephenstroud commented 7 years ago

@RWOverdijk Yes as you can configure the setting. Here: https://github.com/paulvanbladel/aurelia-auth/blob/41b5504fc0aea19ff6f1737a9d880106cea1a5cc/dist/es2015/base-config.js#L87

however, updating it means the default configuration won't be outdated when the API retires, especially helpful for new users etc.

stephenstroud commented 7 years ago

@paulvanbladel Okay thanks