search

paulvanbladel / aurelia-auth

:key: Authentication plugin for aurelia
200 stars 74 forks source link

Fix default headers (#105, #168) #183

Closed ielcoro closed 6 years ago

ielcoro commented 6 years ago

This pull requests reverts the behaviour introduced in #105 and #168 that broke all multipart requests by setting the default Content-Type header to 'application/json', preventing the client to automatically calculating multipart data boundary.

This pull requests removes the default configuration in FetchConfig and instead, approaches the problem by explicitly setting the needed headers for each request in the library, so that the library does not interfere with host applications.

ielcoro commented 6 years ago

@paulvanbladel Should I be worried about the non passing CI checks? Looks like some misconfiguration in Travis tasks?

paulvanbladel commented 6 years ago

no worries :)

ielcoro commented 6 years ago

@paulvanbladel Done. I suggest updating the npm package as this can be considered a high impact hotfix.