search

paulvanbladel / aurelia-auth

:key: Authentication plugin for aurelia
200 stars 74 forks source link

Error thrown from status #97

Closed ashleyschuett closed 8 years ago

ashleyschuett commented 8 years ago

Is there a reason that the status function throws the the statusText from the response when it errors?

Wouldn't it be better to throw the json from the response since the auth might have been rejected for different reasons?

paulvanbladel commented 8 years ago

I think that's updated in the latest bits. Can you check it out please? Thanks

paulvanbladel commented 8 years ago

Oops, you are right, StatusText is still returned :) There was in the mean time PR for this. Will be fixed soon Ashley. Take care paul.

ashleyschuett commented 8 years ago

I updated to 12.8 and that throws the whole response, but it looks like in master it is throwing response.statusText

paulvanbladel commented 8 years ago

yeah, I merged too quickly the PR. Is 12.8 doing what i should do for you?

ashleyschuett commented 8 years ago

Yes, 12.8 has the behavior I would expect.