paulvangentcom / python_corona_simulation

An agent-based simulation of corona and other viruses in python
GNU General Public License v3.0
292 stars 76 forks source link

Some improvement for the project #30

Closed YaoAnthony closed 3 years ago

YaoAnthony commented 3 years ago

Hi! I am Anthony who is a student taking a software design course, and I was the one who asked the question regarding software logic as well. I am really interested in your project as I have also simulated virus spreading and stopping with JAVA. Therefore, as the teacher assigned us the Aggregate Design pattern of DDD, I come here again.

The first point of this pull request is to fulfill the teacher's request. I modified the motion.py content and integrating all methods used to change human action in the simulation.py to a motion class. This might be a good way to accomplish the teacher's task. On the other hand, there is another layer to this integration. I want to complete the hospital hitch in your TODO list. In my project, the hospital hitch is an area divided in the extra place of Janel image, where people have a chance to be admitted to the hospital when they are infected. Thus this pull request integration allows the behavior of sending to hospital isolation to be written all inside the motion.class.

In conclusion, this is a pre-modification of building a hospital project in my idea!