search

paulw11 / Seam3

Cloudkit based persistent store for Core Data
Other
209 stars 25 forks source link

Add Carthage support #64

Closed JonnyBeeGod closed 6 years ago

JonnyBeeGod commented 6 years ago

Can you clarify? Carthage needs a framework and therefor a .xcodeproj so I reused the already existing .xcodeproj from the Examples folder. Do you want me to create a new *.xcodeproj in the root directory?

paulw11 commented 6 years ago

I have never used Carthage, so I am not clear what it needs, but I don't understand why the PR has xcodeproject files for the example apps; The example apps are not Seam3. Seam3 is a framework. The example apps just show how it can be used. When I use cocoa pods to integrate Seam3 with a project I don't get any "example" files in my project.

paulw11 commented 6 years ago

Ok, after some quick reading it looks like we need to create a new Xcode project in the directory above "Example" and create targets in that project for the framework on the three platforms.

JonnyBeeGod commented 6 years ago

okay, I moved the framework targets from the example Xcode project to a newly created xcodeproj in the root directory