paulwedeck / settlers-remake

A Remake of "The Settlers III" for Windows, Linux, Mac and Android
MIT License
116 stars 18 forks source link

[Multiplayer] Changing starting position resets all values to default when starting the match #24

Open Karol-G opened 2 years ago

Karol-G commented 2 years ago

Hi,

if I change the position of a player in the multiplayer lobby together with other changes then none of the other changes take effect when the match is started. Example: I set myself to be position 2 and to amazons. After starting the game I will still be at position 1 and be roman. However, just changing to amazons without changing the position works without problems.

Adiddtionally, any change of any setting will reset the civilization of every player (pressing ready button, changing the team, etc.). Currently the civilization has to be set at the end after every other setting has been adjusted. This bug is independent of the first bug, but maybe related in some form.

Best, Karol

paulwedeck commented 2 years ago

It works for me. What operating system and version of JSettlers are you using?

Karol-G commented 2 years ago

I am using Windows 10 and are using the release v0.5.3-alpha. Is it maybe fixed with a later commit? I tried to build from the latest commit but got an error. So I assume that it is currently not release ready?

paulwedeck commented 2 years ago

I haven't touched this part of the code, so hopefully nothing changes. Do you mean 4300afc with latest commit ? Is your java version up to date? The master version should always at least compile and it usually has the same quality (but obviously less features) as the release version.