search

paulwedeck / settlers-remake

A Remake of "The Settlers III" for Windows, Linux, Mac and Android
MIT License
116 stars 18 forks source link

Music #3

Closed Marvi-Marv closed 3 years ago

Marvi-Marv commented 3 years ago

Hey Paul, in case you like the s3 music, you may want my implementation :) thanks for your contribution to the project

Marvi-Marv commented 3 years ago

Thank you for writing this pr. I would like to have the original music in jsettlers but I didn't find the time yet. Also I only have the gold edition and that saves the music on the cd itself as audio tracks, so the only real way for me to test your pr is if you allow custom sound folders too. I think you should look at extending SoundPlayer and mirror the structure of SoundManager and BackgroundSound, so that your code fits better into the overall project.

Thank you for your feedback Paul. I will try to improve the code as much as possible in order to have a better fit for the overall project. You could create a new folder ("MUSIC" or "Theme") in your s3 install directory and copy the cd audio files there. I am currently working on correcting the building images and ressource requirements for all civilizations.

paulwedeck commented 3 years ago

I am currently working on correcting the building images and ressource requirements for all civilizations.

Great to hear that. If you haven't noticed already: The buildings are mostly defined in xml files in jsettlers.common/src/main/resources/jsettlers/common/buildings/ Also the BuildingCreatorApp in jsettlers.buildingcreator should be helpful. There are also some tests that validate these xml files.

Marvi-Marv commented 3 years ago

I am currently working on correcting the building images and ressource requirements for all civilizations.

Great to hear that. If you haven't noticed already: The buildings are mostly defined in xml files in jsettlers.common/src/main/resources/jsettlers/common/buildings/ Also the BuildingCreatorApp in jsettlers.buildingcreator should be helpful. There are also some tests that validate these xml files.

Yes, i have already found these. And the tools are very helpful. I will push the first changes to my repository branch "AssignCorrectBuildingRessources" later this evening. I am still not entirley sure how i can transform the winegrower to the brewery for instance, but i am fine with the images and the ressources. Do you use some kind of messenger or voice tool in order to communicate?

paulwedeck commented 3 years ago

You should look at the jobs for the backery. They should be much closer to the Brewery than the vineyard is. You also shouldn't "transform" one kind of building to another but create a new entry in EBuildingType, etc. for it. Its not an issue if there isn't a vineyard xml for the egyptians or a brewery for the romans. We have a discord server. Its at the bottom of the readme. https://discord.gg/2hVV4u6

Marvi-Marv commented 3 years ago

added gui and moved files to fit project structure