search

paulwedeck / settlers-remake

A Remake of "The Settlers III" for Windows, Linux, Mac and Android
MIT License
116 stars 18 forks source link

Prevent waves causing UI, units, buildings disappear #46

Closed faerietree closed 2 years ago

faerietree commented 2 years ago

Fix #45

paulwedeck commented 2 years ago

Thank you for the contribution. If again encounter such a bug feel free to just open an issue. May I ask why your installation doesn't have waves? All GFX directories that I know of have them, so you either have a completely different version or jsettlers is bugged on a different way that leads to this bug

HiranChaudhuri commented 2 years ago

Would it be huge effort to have a method that at startup checks if for all the configured civilisations the required resources are available? That could help us figure out problems early.

paulwedeck commented 2 years ago

First of all this isn't about civilization specifc textures. I remember having this discussion in a different issue: Yes, we can at least partially check if the civilization is available but the big question if what we do with this information. Its completely possible to run jsettlers without graphics at all (e.g. unit tests) and we can't prevent mp games with missing civilization textures. The only thing we can do is to check it and notify the user that something is going to be wrong

HiranChaudhuri commented 2 years ago

Yes a notification and some entry in the logs would be sufficient. After all there is no procedure to automatically fix broken or missing files. But once we know the game files are broken we could ask the user to reinstall the game - a job for the installer.

And true: Waves are not civilisation specific.