search

paulwedeck / settlers-remake

A Remake of "The Settlers III" for Windows, Linux, Mac and Android
MIT License
116 stars 18 forks source link

Add checkstyle #53

Closed HiranChaudhuri closed 8 months ago

HiranChaudhuri commented 2 years ago

Automate enforcing of coding guidelines.

HiranChaudhuri commented 2 years ago

I am a bit surprised to see no checkstyle activity in the CI build. But then I realized I was testing locally like

settlers-remake/jsettlers.tools$ ../gradlew clean build

HiranChaudhuri commented 2 years ago

I tried to actually run one of these tests but there are countless warnings. This was to be expected but it kind of questions the point of this pr.

Thinking further, this questions any of your requests to stick to some kind of code formatting. By adding checkstyle I hope to end the formatting discussion and move attention to the semantic level, which is almost not happening at all.