search

paulyarabe / equidestined

1 stars 2 forks source link

TODO #1

Open JeffKatzy opened 7 years ago

JeffKatzy commented 7 years ago

location#get_coordinates_from_api -> consider moving this to a controller instead of having in a model. I prefer models without callbacks, as callbacks mean that an object that is something, always must do something.

midpoint#self.calculate(locations) - you may be able to do find_or_create by multiple attributes, not sure. I like the comments in the searchescontroller - keep that procedure in the controller, and don't use it with callbacks in the model.

n3m3sis42 commented 7 years ago

The #get_coordinates method isn't in use, so I'm removing it. It was only there for testing purposes when we first started.