search

paulyoder / LinqToExcel

Use LINQ to retrieve data from spreadsheets and csv files
MIT License
1.06k stars 299 forks source link

Remove LinqToExcel's dependency on log4net. #107

Closed mrworkman closed 7 years ago

mrworkman commented 8 years ago

This removes log4net as a dependency from LinqToExcel by slipping in some basic interfaces.. log4net can still be used, but it's no longer needed. The tests have been updated to use these interfaces to inject log4net, as the tests do still depend on it.

FYI, also adds nant 0.92-rc1 (which works on Windows 10), you can safely exclude this if the old version still works for you.

paulyoder commented 7 years ago

@mrworkman I like this PR. Unfortunately I don't have time to test it and merge it. Can you take care of that if I make you a collaborator on the project?

mrworkman commented 7 years ago

Absolutely!

On Feb 14, 2017 2:34 PM, "Paul Yoder" notifications@github.com wrote:

@mrworkman https://github.com/mrworkman I like this PR. Unfortunately I don't have time to test it and merge it. Can you take care of that if I make you a collaborator on the project?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/paulyoder/LinqToExcel/pull/107#issuecomment-279811257, or mute the thread https://github.com/notifications/unsubscribe-auth/ATKYhtp1JClBkebrxxpBpda8YPNuHX4hks5rcgGygaJpZM4JsPDH .