search

paulyoder / angular-bootstrap-show-errors

An Angular directive for Bootstrap to intelligently show form validation errors
MIT License
331 stars 77 forks source link

why .form-control is required? #44

Open egorovpavel opened 9 years ago

egorovpavel commented 9 years ago

there may be number of cases when this is not possible due to form markup. One possible solution is to use *[name] instead .form-control['name']

seems it breaks only one spec which tests .form-control class for existence. So there is no reason to restrict to .form-control.

just one of use cases may be directives similar to ui-select or other no standard form controls.

chrisfosterelli commented 9 years ago

+1 because not requiring form-control would also mean that this would work on bootstrap radio buttons, which was added in 2.2.0 but reverted away from in 2.3.0.

leoetlino commented 9 years ago

FYI, this was broken to fix #13.