search

paulyoder / angular-bootstrap-show-errors

An Angular directive for Bootstrap to intelligently show form validation errors
MIT License
331 stars 78 forks source link

Use prefix for directives to avoid namespace collisions #47

Open davestaab opened 9 years ago

davestaab commented 9 years ago

From the angular docs:

Best Practice: In order to avoid collisions with some future standard, it's best to prefix your own directive names. For instance, if you created a <carousel> directive, it would be problematic if HTML7 introduced the same element. A two or three letter prefix (e.g. btfCarousel) works well. Similarly, do not prefix your own directives with ng or they might conflict with directives included in a future version of Angular.

See the Creating Directives section of the Angular Docs.

davestaab commented 9 years ago

Also, your package name ui.bootstrap.showErrors seems to imply you are associated with the Angular ui project. It doesn't appear you are and this seems misleading.

Sorry to sound so negative. Great job on this and great blog post explaining it. Very helpful. :+1: