paulyoung / fontello-cli

Command line interface for fontello.
MIT License
88 stars 30 forks source link

Problem downloading fonts #28

Closed jbeezley closed 5 years ago

jbeezley commented 8 years ago

I'm seeing frequent errors when using this script to download fonts. For example, running the following in a loop will almost always fail within three executions:

fontello-cli --config fontello.config.json install

The stack trace varies, but they usually look like one of the following:

events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: invalid signature: 0x41744d57
    at node_modules/fontello-cli/node_modules/unzip/lib/parse.js:63:13
    at processImmediate [as _immediateCallback] (timers.js:383:17)
events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: invalid distance too far back
    at Zlib._handle.onerror (zlib.js:363:17)

Hitting the /get endpoint with curl always (from what I can tell) results in a valid zip file as a response. It does seem like when it fails the request takes several seconds, but still within the default timeout from needle. In this case, it looks like from the curl response is handling a keep-alive connection. My guess is that needle isn't handling this correctly, but it is difficult to tell for sure.