Report an error on non 200 response & move away from unzip to a stable unzipping lib.

paulyoung / fontello-cli

Command line interface for fontello.

MIT License

88 stars 30 forks source link

Report an error on non 200 response & move away from unzip to a stable unzipping lib. #33

Closed AvnerCohen closed 4 years ago

AvnerCohen commented 5 years ago

In the case of server error (500 usually) the result will flow into the unzip, which will result in cryptic unzip errors. This will stop that earlier on and will report the error.

dlackty commented 4 years ago

Hello, @AvnerCohen Since a similar pull request #35 for unzipper was merged, I rebased and merged one of your commit 4ee8962 in 5d13f0ca9107e2c8a99445033b7c67c71af39681

Thanks for your contribution! A new version Is gonna be released soon.

AvnerCohen commented 4 years ago

Thanks, this issue was a blocker for us and we ended up publishing a fork using unzipper instead of unzip. https://www.npmjs.com/package/fontello-cli2

Please make sure to update when a new release is out, we will be happy to move back to the main package.

dlackty commented 4 years ago

@AvnerCohen The new version was just released on npm registry. Please let me know if you have any problem.