paulyoung
commented
8 years ago Hi @adammockor. Thanks for proposing this.
I think I'd be more open to this if we discussed the changes first and maybe introducing them as smaller pull requests. Namely:
Naming
I'm not sure the name change is necessary. The language is still called Jade.
Tests
Which test runner, matchers, etc
API
For a while I've been meaning to release a version that allows consumers to provide their own version of Jade and pass that to this package.
This would allow them to update Jade independently instead of relying on whatever version is used here.
Could/should we do some sort of version/feature detection that automatically does the right thing for a particular version of Jade?
Changes to Jade's internal architecture
How they affect this project. Given the above points, I think this is the only thing that warrants a breaking change.
Versioning
My current thinking is that a major release should be made based on the internal architecture that's currently supported here. If making an update to support a different internal architecture, that would warrant another major release.
We could provide info such as "v1 supports Jade ^1.9.0, v2 supports Jade ^1.10.0" or whatever is correct.
Jade recently renames itself to pug due to copyright issues and they changing internal architecture prior to 2.0 release.
I mostly done this because of nicer errors messages in my gulp workflow.
PR also includes basic test suite.
Have a nice day!