search

paulyoung / jade-inheritance

Reduce compilation time for Jade files by understanding inheritance.
MIT License
40 stars 13 forks source link

A bug in dependent package character-parser cause error when using relative file path #9

Closed woodpig07 closed 9 years ago

woodpig07 commented 9 years ago

Hello Paul, It looks jade-inheritance depends on jade@~0.34.1, which depends on character-parser@1.0.2. I believe there is a bug in that version so that jade-inheritance keeps failing when input filename has relative path, for example: screen shot 2014-11-13 at 2 12 53 pm

I tried to update character-parser to latest version 1.2.0, then the problem solved. Would you considering upgrade your package with latest version of jade?

Thanks

paulyoung commented 9 years ago

I'd prefer to have a test suite in place before making any changes, just to confirm that there are no regressions.

I have considered changing the API to require an instance of Jade to be provided by consumers, but without tests hard to say which versions are supported.

paulyoung commented 9 years ago

Jade was updated a while back, so I'm closing this one. Thanks @woodpig07!