search

paulyoung / purescript-corefn

A library for working with the PureScript functional core.
Apache License 2.0
23 stars 7 forks source link

Updates for 0.11 #45

Closed joneshf closed 6 years ago

joneshf commented 6 years ago

As discussed in #44, this PR finishes off the 0.11 support.

joneshf commented 6 years ago

:heart:

I wonder if a good check would be to attempt to parse all of the modules in output? Given that there's a good deal of modules being compiled, that ought to provide some pretty decent coverage. What do you think?

paulyoung commented 6 years ago

The output directory for the project itself? That would probably be pretty good coverage. I’ve been working on a hello world project for PureSwift and there’s a decent of of stuff to parse even though the source code is very minimal.

Do you mean as part of the test suite?

joneshf commented 6 years ago

Yep!

Seems like a decent way to stay honest. If we can parse every module that helped make the library, it probably works for most modules out there.

joneshf commented 6 years ago

Tried throwing something together, looks like it's failing on CoreFn.Names: https://travis-ci.org/joneshf/purescript-corefn/jobs/372783958#L1511-L1515

It's already paying off!