search

paulyoung / purescript-corefn

A library for working with the PureScript functional core.
Apache License 2.0
23 stars 7 forks source link

Fix parsing of strings #59

Open anttih opened 5 years ago

anttih commented 5 years ago

This fixes the case where the PS parser has parsed a string with lone surrogates in which case the JSON contains an array of char codes instead of a plain string.

Fixes #57

paulyoung commented 5 years ago

Thanks @anttih!

FYI @felixSchl @hdgarrood @michaelficarra

opyapeus commented 4 years ago

Hi @anttih @paulyoung

It looks good and works fine with my case.

After resolving the conflict and merging this PR, I'd be happy if you could introduce the PSString newtype.

I can work on this if you want to leave it to someone.