paulyoung / purescript-corefn

A library for working with the PureScript functional core.
Apache License 2.0
23 stars 7 forks source link

Fully generalization Module Ann to Module a #62

Open opyapeus opened 4 years ago

opyapeus commented 4 years ago

The title is as it is. Please let me know so that I can fix any concerns.

Motivation for this PR

When I tried to understand how CoreFn works, I thought it would be better to read without annotations.

By generalizing Ann, it became easier to read by applying VoidAnn, for example.

And like this commit, it may be a good idea to write a test module in the test code itself.

P.S. Thanks for merging my previous PR!

paulyoung commented 4 years ago

I’ll try to take a look at this soon.

As mentioned here, in the past I’ve tried to keep this as close to the Haskell implementation as possible.

opyapeus commented 4 years ago

I agreed with your thought. It’s better to submit this changes to the Purescript repo first. So please put this PR on hold now.