search

paupino / psqlpack

A logical database management system for PostgreSQL enabling incremental database deployment.
Apache License 2.0
8 stars 2 forks source link

Work towards further integration tests to support column modification #88

Closed paupino closed 6 years ago

paupino commented 6 years ago

This is a continuation of adding integration tests to the solution and filling out functionality. The major change to help support this is changing constraints from being Option<Vec<_>> to Vec<_> due to low overhead for empty vectors and easier ergonomics while comparing constraints.

This also fixes a big flaw with the integration test connection pools. It now defines a pattern ensuring tests will pass for the right reasons.

cc @justinlatimer

paupino commented 6 years ago

This PR is intended to be a squash merge. Please forgive the bad commit names for WIP (I get paranoid in terms of backups!).

paupino commented 6 years ago

Something this raises in which we'll need to be very careful is minimum supported PG version. I've been running PG 9.6 and PG 10 locally however Travis currently tests against 9.4. We may want to consider testing multiple versions in Travis however we should define what versions of those that we support.

paupino commented 6 years ago

Hmm, I'm getting suspected parallel issues here. It's happening during database creation - it appears on the second run it'll be ok but initial runs come under contention.