search

paurakhsharma / flutter_chord

Lyrics Chord parser for Flutter
MIT License
24 stars 14 forks source link

Option to center lyrics #17

Closed jeremiahlukus closed 1 year ago

jeremiahlukus commented 1 year ago

While this looks fine normally on landscape mode it would be nice to pass in a param like centerText. Are you ok if i send a PR for this?

jeremiahlukus commented 1 year ago
Screen Shot 2023-02-15 at 9 22 02 PM

Here is what is looks like in landscape.

The PR would be making this line https://github.com/paurakhsharma/flutter_chord/blob/main/lib/src/lyrics_renderer.dart#L141 an optional param 

centerLyricText ? CrossAxisAlignment.center : CrossAxisAlignment.start

did not test just assuming looking at the code

Just making sure you are ok with this

paurakhsharma commented 1 year ago

@jeremiahlukus It is a good feature request.

One suggestion, let's use lyricsAlign which takes type of CrossAxisAlignment so that user can have a flexibility of aligning it as they want.

jeremiahlukus commented 1 year ago

Ok the chord.leadingSpace https://github.com/paurakhsharma/flutter_chord/blob/main/lib/src/chord_parser.dart#L145.

Makes this much more interesting. A little more more work than i assumed im going to close this issue.

jeremiahlukus commented 1 year ago

Opening this back up and will start looking into this now that my app is live @paurakhsharma