paurkedal / ocaml-caqti

Cooperative-threaded access to relational data
https://paurkedal.github.io/ocaml-caqti/index.html
GNU Lesser General Public License v3.0
299 stars 36 forks source link

Is Caqti_type.Std.custom still unstable? #99

Closed mooreryan closed 1 year ago

mooreryan commented 1 year ago

In the mli docs, there is a note that says that this function "should be considered experimental and may be revised or removed in a future version". I checked the git blame and that warning has been in the docs for ~5 years, so can we assume that it is no longer unstable? Also, I the 2.0.0 issue didn't mention anything about it, so just wanted to check.

(Related issue)

mooreryan commented 1 year ago

Also related, from this GitHub issue:

I don't advice using custom for common cases, it's easier to stick to tuples.

So, combining what you said there with the "unstable" note in the docs, is it safe to say that custom will be removed in a future release?

paurkedal commented 1 year ago

You are right. It has been around for a long time without a need for reversion, and people are using it anyway.