Style Improvements - Githubissues

pavanagrawal123 / VSNotebooks

Jupyter Notebooks in Visual Studio Code

MIT License

63 stars 2 forks source link

Style Improvements #15

Closed pavanagrawal123 closed 5 years ago

pavanagrawal123 commented 5 years ago

Currently, I think there is a lot of wasted space for all the cards so I was planning on making the following changes:

[X] Reduce gap between cards
[X] Reduce border on cards to 1px and increase opacity to .4
[x] Put the title and action buttons all in one line to save space.
[x] Reduce excess space between the card bottom and next card.
[x] Fix expand button
[x] Card controls should be visible 100% of the time. Let me know if you want to see any other style changes in this issue!

schrodog commented 5 years ago

I agree with you. I think you can limit the gaps between cards as much as possible, reduce size of the 'expand' icon

pavanagrawal123 commented 5 years ago

Great to hear! Here's how it looks so far, I will be adding improvement with the expansion, I'm thinking of completely getting rid of it and replacing it with a 1-line preview of the output and then click to expand.

schrodog commented 5 years ago

i think there's still some space to reduce between output result and the triangle icon, already quite good. In addition, it would be great to allow zoom in and out for images and plots

pavanagrawal123 commented 5 years ago

Yep, ideally I want to just get rid of it and do something like this.

Of course it will look way better, this was just a quick mockup. If we did this, it would save a lot of space with the triangle, and would leave much more space for code/output.

pavanagrawal123 commented 5 years ago

I ended up reducing the gap and the sizes of all the buttons and IMO it looks pretty nice this way. Do you think there should be any other changes in V1.5?

Before and after:

pavanagrawal123 commented 5 years ago

Fixed and shipped.